Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column "name" is not filled #35

Open
nlohmann opened this issue May 18, 2016 · 9 comments
Open

Column "name" is not filled #35

nlohmann opened this issue May 18, 2016 · 9 comments
Labels

Comments

@nlohmann
Copy link

I set up flask-profiler as described in the README, and it works fine so far. However, column "name" is always empty:

dashboard

Apart from that, everything works find - it's just a bit inconvenient to only see the HTTP method.

I am using:

  • Python 2.7.5
  • Flask 0.10.1
  • Flask-Profiler 0.5

I am happy to provide more information if needed.

@nlohmann
Copy link
Author

Update: It seems to work with Internet Explorer (tried 11.0.9600), but the names are missing with Firefox (using 38.7.1). As the latter is my default browser, the issue is still inconvenient.

@muatik
Copy link
Owner

muatik commented May 18, 2016

@xorxor perhaps you have an idea since it looks like a front-end issue?

@syy
Copy link
Contributor

syy commented May 18, 2016

@muatik yes, I am working on new version, including this issue

@muatik muatik added the bug label May 18, 2016
@nlohmann
Copy link
Author

I checked just to make sure: Neither browser gives a Javascript warning, and both browsers are serving the exact same sources.

@divyenduz
Copy link
Contributor

@muatik : I can take this up but I would need help from @xorxor to know about the JS build system, in repo I was only able to find the generated main.js but there are no dev JS files that I can edit. Thanks.

@muatik
Copy link
Owner

muatik commented Oct 22, 2016

I think @xorxor is not interested in the project anymore, are you, @xorxor? If not, I can consider writing front-end side myself, even though I don't like front-end side :)

@divyenduz
Copy link
Contributor

Once the build system is recovered/discovered or in place, I can take the front end part up. Life happens, I understand @xorxor can be pre occupied :)

Let's wait for a while (1 month would be decent amount of time) for response from @xorxor, otherwise I will reverse engineer the already built files and create a JS build system around it.

Thanks :)

@divyenduz
Copy link
Contributor

@muatik : Should I start on reverse engineering the JS build system ? Any preferences on what do you want to use for the new build system ? ( say webpack or something )

@muatik
Copy link
Owner

muatik commented Nov 4, 2016

Okay, I had a chance to talk to @xorxor and he replied that he will not be able to contribute in short term, unfortunately.

If I am supposed to work on the front-end, I would choose bootstrap and native javascript alongside some jquery plugins. I've not been doing anything on the front-end side for considerable time, about 3-4 years so that I feel I lack modern methods.

It is up to you to choose methodologies and technologies. But I think simple, extendable and maintainable solution what we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants