Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LBM for network restore (client-side map-saving) #8

Open
OgelGames opened this issue Nov 7, 2020 · 7 comments
Open

Use LBM for network restore (client-side map-saving) #8

OgelGames opened this issue Nov 7, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@OgelGames
Copy link

https://github.com/mt-mods/travelnet/blob/696548f6d30064db79d4cc161e5b66fa3a0d4711/restore_network_via_abm.lua

@OgelGames OgelGames added the enhancement New feature or request label Nov 7, 2020
@BuckarooBanzay
Copy link
Member

There is a config option (disabled by default) that includes that file:

travelnet/init.lua

Lines 1110 to 1113 in 696548f

if( travelnet.enable_abm ) then
-- restore travelnet data when players pass by broken networks
dofile(travelnet.path.."/restore_network_via_abm.lua");
end

Funny thing: it has a typo: enable_abm ~= abm_enabled 🤦

travelnet.abm_enabled = false;

@S-S-X
Copy link
Member

S-S-X commented Jan 13, 2021

also abm != lbm, it would be better to change that abm to actually be lbm. no reason to do it every 20 sec for every travelnet in active areas.

@BuckarooBanzay
Copy link
Member

also abm != lbm, it would be better to change that abm to actually be lbm. no reason to do it every 20 sec for every travelnet in active areas.

it is not enabled by default, i think the use-case would be to restore the network after a client-side map-save

@wsor4035
Copy link

does this really need to be a a/lbm? couldnt you just handle this update in the right click rather than adding more overhead?

@BuckarooBanzay
Copy link
Member

does this really need to be a a/lbm? couldnt you just handle this update in the right click rather than adding more overhead?

That would work too i guess

@S-S-X
Copy link
Member

S-S-X commented Jan 28, 2022

does this really need to be a a/lbm? couldnt you just handle this update in the right click rather than adding more overhead?

That would work too i guess

I think that wont exactly work. Or more like it already works but UX results are not same.
Reason for this is that you actually have to go through all travelnet boxes in network multiple times as only already visited will be added to network and because of this player needs to visit and update travelnet boxes multiple times.

Actually this might also be reason why it is ABM instead of LBM.

@wsor4035
Copy link

wsor4035 commented Feb 1, 2022

in theory d8c0c9d should have solved the data loss issue

@S-S-X S-S-X mentioned this issue Feb 16, 2022
@BuckarooBanzay BuckarooBanzay changed the title Use LBM for network restore Use LBM for network restore (client-side map-saving) Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants