API Change requests

[josh-griffin]

Just starting a list here for api change requests

Printing

Stocktake

Requisitions

• Charts: https://github.com/openmsupply/remote-server/issues/809

Invoices

• InboundShipmentLine.sentNumberOfPacks / InboundShipmentLine.sentPackSize https://github.com/openmsupply/remote-server/issues/706 (added to that issue, let me know if linked invoice line resolver is needed to display this)
• Allocate placeholders mutation: https://github.com/openmsupply/remote-server/issues/885
• Inbound line tax update https://github.com/openmsupply/remote-server/issues/947
• inbound totals not updated https://github.com/openmsupply/remote-server/issues/923
• Outbound addFromMasterList mutation Outbound add from master list #1015
• InvoiceFilterInput.otherPartyType - Need to filter out inbound shipments with otherPartyType === 'invad'

Items

• See also #513

Names

• hold (from docs: "If this is checked this name can not be used for receiving or issuing goods")

User

• Expose the stores the user is able to log into availableStores / availableStoresOnSite 🤔 ?
• Created by : https://github.com/openmsupply/remote-server/issues/808

Suggestions / options (can ignore)**

• RequisitionLineNode.itemStats -> snapshotItemStats - making the distinction between this and RequisitionLineNode.item.stats clearer https://github.com/openmsupply/remote-server/issues/811

[josh-griffin]

Added:

• [name]onHold ref: Display if a name is on hold before trying to make an invoice #451
• [name]margin ref: Inbound shipment % margin/markup #509
• [item]defaultPrice
• [item]margin

[josh-griffin]

Added:

• Inbound line tax update
• Inbound totals not updated https://github.com/openmsupply/remote-server/issues/923
• StockLineNode.taxPercentage
• Outbound addFromMasterList Outbound add from master list #1015

Question

• https://github.com/openmsupply/remote-server/issues/924 (For tracking)

[josh-griffin]

Added:

• StoreNode.storeName?? - Need a storeID to query for the store name, but don't need a name for stores. This makes querying for a list of stores and their names to display for logging in difficult. Would be nice to flatten the name here - imagine that would be easier to implement and also we save the store to local storage (Last logged in store), so flattening is easy
• InvoiceFilterInput.otherPartyType - Need to filter out inbound shipments with otherPartyType === 'invad'

[mark-prins]

Added note about item issue

[andreievg]

this one is filtered out i think InvoiceFilterInput.otherPartyType - Need to filter out inbound shipments with otherPartyType === 'invad'

[josh-griffin]

Oh, my bad

[mark-prins]

👻

[mark-prins]

time to close this one - all items are moved to individual issues now

[josh-griffin]