Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loading indicators deeper in the react node tree #257

Open
lache-melvin opened this issue Nov 20, 2023 · 0 comments
Open

Move loading indicators deeper in the react node tree #257

lache-melvin opened this issue Nov 20, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lache-melvin
Copy link
Collaborator

Describe the bug

We use the common convention of conditionally displaying a loading indicator or content depending on the status of queries. However, this ternary logic often feels a bit too far up the tree. Unnecessarily removing so much content is quite jarring as a user, and can make you wonder if you clicked something with greater impact that you realised.

e.g.

Sorting this table...
Screenshot 2023-11-20 at 3 52 45 PM

...causes the header to be replaced by the loading indicator, where we only need the rows to reload
Screenshot 2023-11-20 at 3 53 32 PM

Similarly, saving or running a notification...
Screenshot 2023-11-20 at 4 03 27 PM

...causes almost a full page refresh, where a loading indication could probably just sit next to the button clicked:
Screenshot 2023-11-20 at 4 03 35 PM

Expected behaviour

Render loading state as far down the tree as possible, so as to keep as much content constant for the user as possible.

Additional context

Should review where this logic lives... maybe it makes sense to have a blanker loading page on the initial load, but minimise the impact of mutations

@lache-melvin lache-melvin added the bug Something isn't working label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant