Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise normal depth cutoff for variants #915

Open
anoronh4 opened this issue Aug 24, 2021 · 1 comment
Open

revise normal depth cutoff for variants #915

anoronh4 opened this issue Aug 24, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@anoronh4
Copy link
Collaborator

anoronh4 commented Aug 24, 2021

We are currently using a hard cutoff for normal read count of alt alleles:

parser$add_argument('-nc', '--normal-count', type = 'integer', required = FALSE,
default = 3, help = 'Normal variant read support cut-off [default %(default)s]')

With higher depth sequencing in the normal, we see that known mutations are filtered out as normal alt counts rise, even though the frequency is not necessarily high.

There are other hard cutoffs in this script and filter-vcf.py and we should take a look at them too.

@gongyixiao gongyixiao added the enhancement New feature or request label Dec 6, 2021
@gongyixiao gongyixiao added this to the 2.0 milestone Mar 16, 2023
@anoronh4
Copy link
Collaborator Author

anoronh4 commented Mar 29, 2023

based on a group discussion we basically don't want to go in the direction of using a proportion and want to keep using hard cut-offs. For any new assays such as IMPACT, we will use the cutoffs from other pipelines as guidance such as argos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants