Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Other mods can't modify whether toasts have sound or not #138

Open
antieksi opened this issue May 19, 2024 · 1 comment
Open

[Bug]: Other mods can't modify whether toasts have sound or not #138

antieksi opened this issue May 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@antieksi
Copy link

What happened?

I use a mod called Music Notification. The mod has an option to turn off popup sound for either only its toasts or for all toasts that do exist in the game. Unfortunately, seems like BRB prevents mods from modifying toast sound behavior — and I mean any mods, because it also happened to me a while ago, though while I was using different mods that edit the processes behind playing music (I don't remember which ones was I using at the time, and looks like they never updated from 1.19.4).

If this can be useful, here's an original issue I made on Music Notification's issue tracker: KosmoMoustache/MusicNotification#41

Modloader

Fabric (Default)

Minecraft Version

1.20.1

Mod Version

v1.10.0+1.20.0-1

Relevant log output

None
@antieksi antieksi added the bug Something isn't working label May 19, 2024
@mrshmllow
Copy link
Owner

I think affecting all toasts is out of scope for this mod these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants