fix: Fix any initialization errors in getFormats() (e.g. IllegalArgumentException - width must be positive)
#3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gumentException - width must be positive`)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes any kinds of initialization errors in
getFormats()that could cause the app to crash when starting up (as constants are evaluated outside of the React Native JS code / error handler).We just wrap it in a
try/catch, and if for some reason any of those getters throw (which they definitely should not do, according to the Android documentation), then we catch and ignore that specific format.Those getters can only throw if the host OS (Samsung, Huawei, ..) has implemented the Android spec poorly or missed something. In that case, it's not my fault, but I have to work around those issues anyways.
Changes
Tested on
Related issues