You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current definition of IndentOpt exposes the type variable b representing the type of block elements to be parsed. In my opinion it makes more sense to existentially quantify this variable in the constructors instead. This gives block parsers more flexibility on the type of items they are parsing.
This also gives the type a straightforward Functor instance.
Is this a change you would consider accepting? It is not backwards compatible and would require the ExistentialQuantification extension. I'd be happy to make a PR.
The text was updated successfully, but these errors were encountered:
This is probably better typing in this case, yes. It would make sense to merge this if we ever decide to bump the major version, but I'm not sure when that will happen.
The current definition of
IndentOpt
exposes the type variableb
representing the type of block elements to be parsed. In my opinion it makes more sense to existentially quantify this variable in the constructors instead. This gives block parsers more flexibility on the type of items they are parsing.The current definition is like this:
and I am suggesting changing it to:
This also gives the type a straightforward
Functor
instance.Is this a change you would consider accepting? It is not backwards compatible and would require the
ExistentialQuantification
extension. I'd be happy to make a PR.The text was updated successfully, but these errors were encountered: