Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderTarget: Fix copy of images. #30570

Merged
merged 1 commit into from
Feb 20, 2025
Merged

RenderTarget: Fix copy of images. #30570

merged 1 commit into from
Feb 20, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 20, 2025

Fixed #30540.

Description

Makes sure render targets do not copy the source/image references of their textures but clone them. This makes sure the renderer detects the correct texture that should be attached to framebuffers.

@Mugen87 Mugen87 added this to the r174 milestone Feb 20, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.65
78.39
336.65
78.39
+0 B
+0 B
WebGPU 522.23
144.94
522.23
144.94
+0 B
+0 B
WebGPU Nodes 521.7
144.84
521.7
144.84
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.64
112.24
465.7
112.26
+55 B
+21 B
WebGPU 592.61
160.56
592.66
160.58
+55 B
+17 B
WebGPU Nodes 547.74
150
547.79
150.02
+55 B
+14 B

@Mugen87 Mugen87 merged commit 2ab9aea into mrdoob:dev Feb 20, 2025
12 checks passed
Mugen87 added a commit that referenced this pull request Feb 20, 2025
Mugen87 added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depthTexture share source after RenderTarget.clone()
1 participant