Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of Precision in 02_pytorch_classification.ipynb is wrong. #1171

Open
danli349 opened this issue Jan 27, 2025 · 3 comments · May be fixed by #1176
Open

The definition of Precision in 02_pytorch_classification.ipynb is wrong. #1171

danli349 opened this issue Jan 27, 2025 · 3 comments · May be fixed by #1176

Comments

@danli349
Copy link

Hello;

The definition of Precision: Proportion of true positives over total number of samples. Higher precision leads to less false positives (model predicts 1 when it should've been 0). in "02_pytorch_classification.ipynb" is wrong.
Precision is the proportion of true positives over positive predictions (not the total number of samples).
Image

Thanks

@37Lime 37Lime linked a pull request Jan 30, 2025 that will close this issue
@37Lime
Copy link

37Lime commented Jan 30, 2025

Hi,

I have created a PR for this Issue.

To clarify, precision is calculated as TP / (TP + FP), where TP = True Positives and FP = False Positives.

Best wishes.

@danli349
Copy link
Author

@37Lime The positive predictions include true positives and false postives.

@37Lime
Copy link

37Lime commented Jan 31, 2025

@danli349 Sorry, I misinterpreted your sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants