Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro regression test needed #336

Open
zebmason opened this issue May 24, 2020 · 5 comments
Open

Micro regression test needed #336

zebmason opened this issue May 24, 2020 · 5 comments

Comments

@zebmason
Copy link
Contributor

@weshinsley @dlaydon @NeilFerguson
For debugging purposes, etc.
Must work as many code paths as possible
Completes in a few seconds

@zebmason
Copy link
Contributor Author

@matt-gretton-dann
Further thought is that on CI we should run (in order):
build
unit tests
micro regression
UK regression
US regression

as the first step to fail causes the job to end

@ozmorph
Copy link
Contributor

ozmorph commented May 24, 2020

@zebmason

Would it make sense for UK regression go last since it takes the longest? On my computer, US regression takes a couple minutes whereas UK regression takes 20-30 minutes.

@zebmason
Copy link
Contributor Author

@ozmorph
I never checked just presumed the US was larger.

@ozmorph
Copy link
Contributor

ozmorph commented May 24, 2020

@zebmason No worries!

FYI for future reference, you can tell what each regression test is using by looking in the admin-params.txt file. The UK regression test includes Wales and the US regression test includes Wyoming. Presumably these were picked because they are the smallest administrative units for each country by population.

@zebmason
Copy link
Contributor Author

One possibility is to run ctest --stop-on-failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants