Merge pull request #19 from mrbar42/webpack4-plugin-fix

explicitly check webpack version major, add plugin tests

index.ts

@@ -61,7 +61,8 @@ class IgnoreEmitPlugin {
     };
 
     // webpack 5
-    if (compiler.hooks && compiler.hooks.compilation && version) {
+    if (compiler.hooks && compiler.hooks.compilation && version && Number(version[0]) > 4) {
+      this.DEBUG && console.log('Using Webpack5 format');
       compiler.hooks.compilation.tap(
         'IgnoreEmitPlugin',
         (compilation: Compilation) => {
@@ -85,10 +86,12 @@ class IgnoreEmitPlugin {
     }
     // webpack 4
     else if (compiler.hooks && compiler.hooks.emit) {
+      this.DEBUG && console.log('Using Webpack4 format');
       compiler.hooks.emit.tap('IgnoreEmitPlugin', ignoreAssets);
     }
     // webpack 3
     else {
+      this.DEBUG && console.log('Using Webpack3 or older format');
       // @ts-ignore - this signature does not exist on the latest webpack typing
       compiler.plugin('emit', (compilation, callback) => {
         ignoreAssets(compilation);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ignore-emit-webpack-plugin",
-  "version": "2.0.5",
+  "version": "2.0.6",
   "description": "Prevents ignored files from being emitted during a Webpack build",
   "scripts": {
     "test:webpack": "bash test/run-tests.sh",

test/run-tests.sh

@@ -8,14 +8,15 @@ function run() {
     exit 1
   fi
 
-  npm ci
+#  npm ci
 
   test_webpack "Webpack3" "[email protected] webpack-cli@2" "webpack3.config.js" || failed=1
   test_webpack "Webpack4" "[email protected] webpack-cli@3" "webpack4.config.js" || failed=1
   test_webpack "Webpack5" "[email protected] webpack-cli@4" "webpack5.config.js" || failed=1
   test_webpack "WebpackLatest" "webpack@latest webpack-cli@latest" "webpack.config.js" || failed=1
+  test_webpack "Webpack4+Plugins" "[email protected] webpack-cli@3 [email protected]" "webpack-terser.config.js" || failed=1
 
-  npm ci
+#  npm ci
 
   if [[ "$failed" ]]; then
     echo "Some tests failed!"
@@ -42,7 +43,7 @@ function test_webpack() {
   fi
 
   # build
-  output="$(node_modules/.bin/webpack --config "test/$config" 2>&1)"
+  output="$(node_modules/.bin/webpack --config "test/$config" --bail --color 2>&1)"
   echo "$output"
 
   does_contain_deprecation=$(echo "$output" | grep -i "Warning" || echo '')

test/webpack-terser.config.js

@@ -0,0 +1,26 @@
+'use strict';
+
+const webpack = require('webpack');
+const IgnoreEmitPlugin = require('../');
+const TerserPlugin = require('terser-webpack-plugin');
+
+module.exports = {
+  bail: true,
+  mode: 'production',
+  entry: {
+    app: './test/app.js'
+  },
+  output: {
+    publicPath: '',
+    chunkFilename: `[name].js`,
+    path: __dirname + '/tmp'
+  },
+  plugins: [
+    new IgnoreEmitPlugin(/chunk\.js$/, {debug: true}),
+    new webpack.SourceMapDevToolPlugin()
+  ],
+  optimization: {
+    minimize: true,
+    minimizer: [new TerserPlugin()]
+  }
+};