From 96e1fabc23d47ae978aebbe48c9afdee034269bb Mon Sep 17 00:00:00 2001 From: Matt Raible Date: Sun, 3 Dec 2023 08:55:20 -0700 Subject: [PATCH 1/2] Formatting --- README.adoc | 4 ++-- src/app/edit/edit.component.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.adoc b/README.adoc index d220a566..e7ddb0c9 100644 --- a/README.adoc +++ b/README.adoc @@ -625,7 +625,7 @@ Modify `EditComponent` to import model and service classes and to use the `Searc [source,typescript] .src/app/edit/edit.component.ts ---- -import { Component, OnInit, OnDestroy } from '@angular/core'; +import { Component, OnDestroy, OnInit } from '@angular/core'; import { Person, SearchService } from '../shared'; import { Subscription } from 'rxjs'; import { ActivatedRoute, Router } from '@angular/router'; @@ -677,7 +677,7 @@ export class EditComponent implements OnInit, OnDestroy { async gotoList() { if (this.person) { - await this.router.navigate(['/search', {term: this.person.name} ]); + await this.router.navigate(['/search', {term: this.person.name}]); } else { await this.router.navigate(['/search']); } diff --git a/src/app/edit/edit.component.ts b/src/app/edit/edit.component.ts index 515665c8..afe88c4a 100644 --- a/src/app/edit/edit.component.ts +++ b/src/app/edit/edit.component.ts @@ -1,4 +1,4 @@ -import { Component, OnInit, OnDestroy } from '@angular/core'; +import { Component, OnDestroy, OnInit } from '@angular/core'; import { Person, SearchService } from '../shared'; import { Subscription } from 'rxjs'; import { ActivatedRoute, Router } from '@angular/router'; @@ -50,7 +50,7 @@ export class EditComponent implements OnInit, OnDestroy { async gotoList() { if (this.person) { - await this.router.navigate(['/search', {term: this.person.name} ]); + await this.router.navigate(['/search', {term: this.person.name}]); } else { await this.router.navigate(['/search']); } From ae4e5b5c0dfb20422c10fb4ebfa518c61bb81b31 Mon Sep 17 00:00:00 2001 From: Matt Raible Date: Mon, 4 Dec 2023 17:41:37 -0700 Subject: [PATCH 2/2] Update Cypress CI to use localhost (#141) --- .github/workflows/main.yml | 2 +- README.adoc | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9486f5d0..8be16a5c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,4 +30,4 @@ jobs: with: start: npm start install: false - wait-on: 'http://[::1]:4200' + wait-on: http://localhost:4200 diff --git a/README.adoc b/README.adoc index e7ddb0c9..f7332a56 100644 --- a/README.adoc +++ b/README.adoc @@ -1381,11 +1381,9 @@ jobs: browser: chrome start: npm start install: false - wait-on: http://[::1]:4200 + wait-on: http://localhost:4200 ---- -TIP: See https://github.com/cypress-io/github-action/issues/634[issue #634] for more information on the strange syntax for `wait-on`. - Check it in on a branch, create a pull request for that branch, and you should see your tests running. === Jenkins