Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_allow_empty rename to allow_empty or change to on_empty? #105

Closed
mathause opened this issue Oct 11, 2024 · 1 comment · Fixed by #112
Closed

_allow_empty rename to allow_empty or change to on_empty? #105

mathause opened this issue Oct 11, 2024 · 1 comment · Fixed by #112

Comments

@mathause
Copy link
Collaborator

For the _allow_empty keyword I initially added the underscore to make a name conflict with a placeholder less likely. This was exaggerated to begin with but after #99 we can change it with confidence. But what should we do exactly?

  1. leave it be
    • no work, but I am no fan of the underscore
  2. rename to allow_empty
    • definitely a better name, but maybe a bit overkill
  3. rename to on_empty with the options "raise" | "warn" | "???"
    • would align with on_parse_error & add an option ("warn")
    • but what name should the third option be? ("ignore" seems wrong)
  4. something else?

@veni-vidi-vici-dormivi I am asking once again for your opinion 🤷‍♂️

@veni-vidi-vici-dormivi
Copy link
Collaborator

I like on_empty and "raise" | "warn" | "pass"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants