Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quantity_spec members #654

Open
mpusz opened this issue Dec 5, 2024 · 0 comments
Open

quantity_spec members #654

mpusz opened this issue Dec 5, 2024 · 0 comments
Labels
design Design-related discussion question Further information is requested refactor Modify existing code potentially causing breaking changes
Milestone
v2.5.0

Comments

@mpusz
Copy link
Owner

mpusz commented Dec 5, 2024

quantity_spec is the only SymbolicConstant that has public members (dimension and character). named_unit, point origins, other SymbolicConstants, and even reference do not expose anything. Only quantity and quantity_point expose public members.

Should we continue doing that, or should we provide an alternative interface to obtain this information (e.g., get_dimension(QuantitySpec), get_character(QuantitySpec))?
@mpusz mpusz added question Further information is requested refactor Modify existing code potentially causing breaking changes labels Dec 5, 2024
@mpusz mpusz added this to the v2.5.0 milestone Dec 30, 2024
@mpusz mpusz added the design Design-related discussion label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design-related discussion question Further information is requested refactor Modify existing code potentially causing breaking changes
Projects
None yet
Milestone
v2.5.0
Development

No branches or pull requests
1 participant
@mpusz