Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide angular units #171

Closed
teajay-fr opened this issue Oct 1, 2020 · 3 comments
Closed

Provide angular units #171

teajay-fr opened this issue Oct 1, 2020 · 3 comments
Labels
not a bug Shit happens...

Comments

@teajay-fr
Copy link

Currently no angular units are provided.
This would be necessary to be able to handle all rotational phenomenon such as a rotating wheel or motor :)

The required base units would be:

  • degrees
  • radians
  • grad
    Angular velocity and acceleration would also make sense.
@teajay-fr teajay-fr changed the title No angular quantities Provide angular quantities Oct 1, 2020
@teajay-fr teajay-fr changed the title Provide angular quantities Provide angular units Oct 1, 2020
@mpusz
Copy link
Owner

mpusz commented Oct 1, 2020

Actually, it is not true.

In the following directory https://github.com/mpusz/units/tree/master/src/include/units/generic you will find both an experimental angular dimension and a dimensionless quantity. Here https://github.com/mpusz/units/blob/master/src/include/units/physical/si/derived/angular_velocity.h you can find the implementation of the angular_velocity that uses this experimental angle unit. We also have torque: https://github.com/mpusz/units/blob/master/src/include/units/physical/si/derived/torque.h.

It is still unclear if we should stay with an angular dimension or use dimensionless quantity for those. You can find the discussion in #99. We need more experience and this is why we have both options for now here.

Regarding degrees vs radians we have another big issue here as pi would need to be encoded as a compile-time ratio which will result in ratio overflows easily. See more in #169.

@teajay-fr
Copy link
Author

Thank you for pointing this out, I missed the discussion and units already present in my research. I'll close this issue and add some input to the other discussions.

@mpusz
Copy link
Owner

mpusz commented Sep 1, 2022

Implemented with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not a bug Shit happens...
Projects
None yet
Development

No branches or pull requests

2 participants