Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to New Architecture #49

Open
mpiannucci opened this issue Apr 3, 2022 · 11 comments
Open

Migrate to New Architecture #49

mpiannucci opened this issue Apr 3, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@mpiannucci
Copy link
Owner

mpiannucci commented Apr 3, 2022

Tracking issue for migrating the package to use the New Module Architecture: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/enable-libraries-prerequisites.md

UPDATE 8/8/2024: After testing the example app in new architecture mode the library seems to work ok. I am leaving this open as tracking issue for updating to the fabric and turbomodule apis. If there are issues with using as is in a new architecture app, please mention you issues here

@mpiannucci mpiannucci added the enhancement New feature or request label Apr 3, 2022
@anton-patrushev
Copy link

any progress here?

@castdrian
Copy link

doesn't look like it

@elsa17z
Copy link

elsa17z commented Jul 24, 2024

This is 1 of the 17 packages I have that currently do not support new architecture, commenting to keep myself posted

@yzhe554
Copy link

yzhe554 commented Aug 8, 2024

Any update for this issue?

@castdrian
Copy link

just use tamagui or something

@mpiannucci
Copy link
Owner Author

I do want to migrate to new architecture..

But there isn't really a performance hit for this project on your app, so it's not like you're going to get some crazy improvement from it going new architecture. I understand why everyone wants it, but it's going to take me time to do so and I don't have a lot of it.

@castdrian
Copy link

Well your package is simply broken for all recent projects, hence just use tamagui people or similar pure js libs

@mpiannucci
Copy link
Owner Author

Well your package is simply broken for all recent projects, hence just use tamagui people or similar pure js libs

Is it actually broken? If so can you post an error? I just did a test on ios and it is working fine for me in bridgeless mode

Screenshot 2024-08-08 at 2 01 23 PM

@mpiannucci
Copy link
Owner Author

mpiannucci commented Aug 8, 2024

marked compatible after testing: react-native-community/directory#1236

@Robert27
Copy link

Not fully compatible for me tho. After upgrading to the new arch the preview is rendered as an empty view with only the background visible.

@joekendal
Copy link

@castdrian tamagui doesn't have ios 3D touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants