Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle file uploads #1

Open
mpclarkson opened this issue Jun 1, 2016 · 4 comments
Open

Handle file uploads #1

mpclarkson opened this issue Jun 1, 2016 · 4 comments
Labels
enhancement help wanted

Comments

@mpclarkson
Copy link
Owner

This is the last remaining part of the API to implement. PR's welcome :)
@ehmjaysee
Copy link
Contributor

I see a pull request is pending for /uploads feature.

@ehmjaysee
Copy link
Contributor

The pull request is just a single code line so it makes me wonder if uploads is already supported by StravaSwift and now it is just a matter of bug fix?

@ehmjaysee
Copy link
Contributor

Got this working and submitted a PR with minimal changes required for file upload and monitoring.

I also updated the Example project to support a file upload and monitoring of the upload and segment analysis. In order to run the Example project I also needed to update the project for Xcode13 and iOS 13+ which are straightforward but generated a huge code churn in the Example project. I will submit that as a separate PR.

@jeffbailey
Copy link

Any update on this? I've LOVE to get the PR merged. I've been using the changes for a few months now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffbailey @mpclarkson @ehmjaysee