Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with my setup (express 5.0-alpha) #101

Open
MoMannn opened this issue Sep 15, 2021 · 2 comments
Open

Not working with my setup (express 5.0-alpha) #101

MoMannn opened this issue Sep 15, 2021 · 2 comments

Comments

@MoMannn
Copy link

MoMannn commented Sep 15, 2021

I cannot get the generator to work and I'm not sure if the problem is the express version I am using (5.0 alpha) or maybe my server structure.

I created an example demonstrating my error: https://github.com/MoMannn/express-oas-generator-example

Just run npm run start.

@maxiejbe
Copy link
Contributor

maxiejbe commented Oct 4, 2021

Hi @MoMannn,

I've not tested it again Express 5.0 as it's still alpha, let me give it a try.
But if it doesn't work any version we ship will probably break backwards compatibility and requires shipping a major @mpashkovskiy.

Best,

@sphinxrave
Copy link

Can confirm it doesn't work against express 5.0

Some fixes:
var stack = app.stack || (app.router && app.router.stack)

express doesn't have app._router anymore, so we have to use .router

However, it still doesn't work as it doesn't go through the tree correctly, only /leafURL show up in the generated swagger doc, instead of /branch/leafURL

@mpashkovskiy mpashkovskiy mentioned this issue Jul 13, 2022
10 tasks
@mpashkovskiy mpashkovskiy changed the title Not working with my setup Not working with my setup (express 5.0-alpha) Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants