Skip to content
This repository was archived by the owner on May 11, 2020. It is now read-only.

French department of Martinique : no area code available #109

Open
iolkan opened this issue Mar 29, 2015 · 9 comments
Open

French department of Martinique : no area code available #109

iolkan opened this issue Mar 29, 2015 · 9 comments
Labels
Milestone

Comments

@iolkan
Copy link

iolkan commented Mar 29, 2015

Hi,
I'm trying to install openwapp in Martinique, but there's no area code available when I select this area, only a "+" symbol. Then it displays an error number if I try to register. (Open C ZTE phone)
Thanks in advance!
Iolkan

@willyaranda
Copy link
Member

Ouch, it's true!

https://github.com/mozillahispano/openwapp/blob/master/app/scripts/countries.json#L7456

What is the country code?

Ping @duesenfranz as he is the creator of the original code and python converter.

@willyaranda willyaranda added this to the 1.8.0 milestone Mar 30, 2015
@duesenfranz
Copy link
Contributor

Oh yeah, that was an error in the csv file, which is however fixed by this commit.

This seems correct, and is also what google tells me...

@willyaranda , i re-ran the script and also added sorting to the json file for easier diffing in the future here; you think it's ready to push?

@willyaranda
Copy link
Member

If it does not break anything, yeah :) Please upload the new version, and I will push a new version to the marketplace.

Thanks!

@Timmaks
Copy link
Contributor

Timmaks commented Mar 30, 2015

Don't push a new version to the narket place before my pr is committed. There is a l10n error in the currunt version of master who results in a white screen. Fixed by the latest pull request

@iolkan
Copy link
Author

iolkan commented Mar 30, 2015

the code is +596
:)

  De : Guillermo López Leal <[email protected]>

À : mozillahispano/openwapp [email protected]
Cc : iolkan [email protected]
Envoyé le : Lundi 30 mars 2015 4h56
Objet : Re: [openwapp] French department of Martinique : no area code available (#109)

Ouch, it's true!https://github.com/mozillahispano/openwapp/blob/master/app/scripts/countries.json#L7456What is the country code?Ping @duesenfranz as he is the creator of the original code and python converter.—
Reply to this email directly or view it on GitHub.

@Timmaks
Copy link
Contributor

Timmaks commented Mar 30, 2015

@willyaranda i planned to update the l10n files this Wednesday, can you wait till then with the push to marketplace so the work in transifex is in the next official build?

@willyaranda
Copy link
Member

Yes, no problems.

2015-03-30 17:30 GMT+02:00 T.M. van den Broek [email protected]:

@willyaranda https://github.com/willyaranda i planned to update the
l10n files this Wednesday, can you wait till then with the push to
marketplace so the work in transifex is in the next official build?


Reply to this email directly or view it on GitHub
#109 (comment)
.

Guillermo López [willyaranda]
http://mozilla-hispano.org
http://twitter.com/mozilla_hispano
http://facebook.com/mozillahispano
Certified Mozillian: https://mozillians.org/willyaranda

@Timmaks
Copy link
Contributor

Timmaks commented Jun 25, 2015

@duesenfranz please push this to the master so we can release a 1.8 version to the marketplace

@Timmaks
Copy link
Contributor

Timmaks commented Nov 9, 2015

@duesenfranz are you planning to fix this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants