Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

transfer sphinx-js project #233

Closed
3 of 6 tasks
willkg opened this issue Sep 28, 2023 · 15 comments
Closed
3 of 6 tasks

transfer sphinx-js project #233

willkg opened this issue Sep 28, 2023 · 15 comments

Comments

@willkg
Copy link
Member

willkg commented Sep 28, 2023

Issue #226 caused us to sit down and figure out the future of this project. @hoodmane is maintaining a fork for pyodide. We worked out that we're going to transfer this project to @hoodmane.

This covers the tasks to transfer:

  • remove CODE_OF_CONDUCT.md
  • go through and remove Mozilla branding--this will no longer be a Mozilla-owned project
  • remove author names where appropriate with a TODO to fill new ones in
  • transfer project to new owner
  • update permissions
  • update pypi permissions
@willkg willkg mentioned this issue Sep 28, 2023
@hoodmane
Copy link

remove CODE_OF_CONDUCT.md

Seems like a fine code of conduct but I guess it is very Mozilla branded. I guess we can copy our own version from here:
https://github.com/pyodide/pyodide/blob/main/CODE-OF-CONDUCT.md

remove author names where appropriate

I'm always confused about what the etiquette is with this for forks and ownership transfers. I think that the original authors are still authors but no longer maintainers. The primary argument for removing old people is if they want to be removed for some reason or if they are getting contacted by people about it? What do you think?

cc @rth @ryanking13 @erikrose

Thanks again @willkg for your work on this project!

@willkg
Copy link
Member Author

willkg commented Sep 28, 2023

In other projects, I have a contributors file where people who've contributed are listed. This project doesn't do that, but it could. We could seed it with the git committers.

I find "authors" and "maintainers" project metadata which gets tracked in various places to be an invitation for users to contact when they need help. Thus, people who aren't active on a project shouldn't be listed there.

I'm not aware of any virtues to being listed in "authors" or "maintainers" but not being active.

You can always change it when you take over.

@hoodmane
Copy link

hoodmane commented Sep 28, 2023

The only reason I'm sensitive of this point is that I observed an argument about it in the past: a new maintainer removed the previous maintainer from the authors list and the old maintainer got angry.

"authors" and "maintainers" project metadata which gets tracked in various places to be an invitation for users to contact when they need help. Thus, people who aren't active on a project shouldn't be listed there.

This seems like a good argument.

@willkg
Copy link
Member Author

willkg commented Sep 28, 2023

I respect the work Erik put into sphinx-js and you're right--we shouldn't just drop things like that entirely. I added a CONTRIBUTORS file like I have with Bleach in PR #234. Does that look ok?

@hoodmane
Copy link

Looks great.

@rth
Copy link

rth commented Sep 28, 2023

Seems like a fine code of conduct but I guess it is very Mozilla branded. I guess we can copy our own version from here:
pyodide/pyodide@main/CODE-OF-CONDUCT.md

Ours is probably also a bit Mozilla branded, as we didn't change it from the time when Pyodide was a Mozilla project :)

@hoodmane
Copy link

At least Pyodide's COC doesn't tell you to email Mozilla to report violations though...

@erikrose
Copy link
Contributor

Thanks for taking on the mantle, @hoodmane! I'm fine being listed as author, as I've never got direct mails from anyone on any other of my projects emeritus. However, I've always encouraged maintainers down the line to stick themselves in there instead. All I would request is I'm listed in the readme as originating the project so I don't seem like a liar when I cite it in my resume etc. Thanks again for taking over! :-D

@willkg
Copy link
Member Author

willkg commented Sep 28, 2023

I added a Provenance section to the README about where sphinx-js originated and also pointing to the CONTRIBUTORS file for details. I think that covers things.

@erikrose
Copy link
Contributor

erikrose commented Sep 28, 2023 via email

willkg added a commit that referenced this issue Sep 29, 2023
willkg added a commit that referenced this issue Sep 29, 2023
@willkg
Copy link
Member Author

willkg commented Oct 2, 2023

I wrote up a bug to transfer the project from mozilla to pyodide. I'm not sure how long it'll take, but I'll keep tabs on it.

@raucao
Copy link

raucao commented Jan 17, 2024

Is something still blocking the repo from being transferred? The tasks seem to have been completed, and only the actual transfer seems to be left to do.

@willkg
Copy link
Member Author

willkg commented Sep 23, 2024

We've been working on this for slightly under a year now.

The thing that's holding everything up is paperwork we need signed before we can do the transfer. @hoodmane and I are still working on it, but there's no ETA.

@willkg willkg pinned this issue Sep 23, 2024
@willkg
Copy link
Member Author

willkg commented Dec 18, 2024

I haven't heard any updates in many many weeks. I don't want to keep sitting on this, so I'm changing gears and I'm going to deprecate the project.

I'll close this out in favor of #247 . Sorry!

@willkg willkg closed this as completed Dec 18, 2024
@hoodmane
Copy link

It's unfortunate that the Open Source Collective doesn't seem able to sign legal agreements. Thanks for trying though @willkg. I suppose if we want we can perfectly well publish under sphinx-js-2 or sphinx-js-maintained or some other name.

@willkg willkg unpinned this issue Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants