-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ES2023 Change Array by copy #1307
Comments
Hello, |
Yes, we'd welcome a PR for this Check Contributing PRs for some guidelines and pointers As for tests: unfortunately we cannot run the latest version of the Test262 testsuite, which means the Change Array by Copy tests are not included yet within Rhino. So depending on your timeline, you'll need to include tests yourself or we might be able to switch to the latest version of Test262 before you're finished, see (#958) |
Cool, please assign the issue to me. I am reading the docs to get an understanding of the changes. I will post any question in the Google group. |
We don't typically assign issues to people, just submit a PR and everything will work out. |
Thanks, I will be able to start work late next week. |
FYI: I just found out that all TypeArray implementations that Rhino supports are missing (almost) all methods that they ought to share with regular Arrays. As such, I think there might be way more to it to also implement the new methods that are part of the 'Change Array by Copy' proposal to all Typed Arrays, so maybe use this case to just add the proposed methods to NativeArray and let the TypedArray part of the proposal be part of #1411 |
Proposal: https://github.com/tc39/proposal-change-array-by-copy
The text was updated successfully, but these errors were encountered: