Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES2023 Change Array by copy #1307

Closed
p-bakker opened this issue Mar 4, 2023 · 6 comments · Fixed by #1569
Closed

Support ES2023 Change Array by copy #1307

p-bakker opened this issue Mar 4, 2023 · 6 comments · Fixed by #1569
Labels
Arrays Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec feature Issues considered a new feature good first issue Great place to start if you're looking to start an open source "resume"
Milestone

Comments

@p-bakker
Copy link
Collaborator

p-bakker commented Mar 4, 2023

Proposal: https://github.com/tc39/proposal-change-array-by-copy

@p-bakker p-bakker added this to the ES2023 milestone Mar 4, 2023
@p-bakker p-bakker added feature Issues considered a new feature good first issue Great place to start if you're looking to start an open source "resume" labels Oct 16, 2023
@pkkht
Copy link

pkkht commented Oct 23, 2023

Hello,
Thanks for flagging this as "good first issue". Can I work on this please.

@p-bakker
Copy link
Collaborator Author

Yes, we'd welcome a PR for this

Check Contributing PRs for some guidelines and pointers

As for tests: unfortunately we cannot run the latest version of the Test262 testsuite, which means the Change Array by Copy tests are not included yet within Rhino.

So depending on your timeline, you'll need to include tests yourself or we might be able to switch to the latest version of Test262 before you're finished, see (#958)

@pkkht
Copy link

pkkht commented Oct 23, 2023

Cool, please assign the issue to me. I am reading the docs to get an understanding of the changes. I will post any question in the Google group.

@p-bakker
Copy link
Collaborator Author

We don't typically assign issues to people, just submit a PR and everything will work out.

@pkkht
Copy link

pkkht commented Oct 27, 2023

Thanks, I will be able to start work late next week.

@p-bakker
Copy link
Collaborator Author

p-bakker commented Nov 3, 2023

FYI: I just found out that all TypeArray implementations that Rhino supports are missing (almost) all methods that they ought to share with regular Arrays.

As such, I think there might be way more to it to also implement the new methods that are part of the 'Change Array by Copy' proposal to all Typed Arrays, so maybe use this case to just add the proposed methods to NativeArray and let the TypedArray part of the proposal be part of #1411

@p-bakker p-bakker linked a pull request Nov 12, 2023 that will close this issue
@p-bakker p-bakker added the Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrays Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec feature Issues considered a new feature good first issue Great place to start if you're looking to start an open source "resume"
Projects
None yet
2 participants