Bug: Default ignoreProps array is missing X-MOZ-LASTACK and X-MOZ-GENERATION

[titanism]

Per

releases-comm-central/calendar/base/modules/utils/calItemUtils.sys.mjs

Lines 407 to 417 in 2e0cd2b

	const ignoreProps = arr2hash(
	aIgnoreProps || [
	"SEQUENCE",
	"DTSTAMP",
	"LAST-MODIFIED",
	"X-MOZ-GENERATION",
	"X-MICROSOFT-DISALLOW-COUNTER",
	"X-MOZ-SEND-INVITATIONS",
	"X-MOZ-SEND-INVITATIONS-UNDISCLOSED",
	]
	);

the following two properties need added:

• X-MOZ-LASTACK
• X-MOZ-GENERATION

The change would look like this:

  compareContent(aFirstItem, aSecondItem, aIgnoreProps, aIgnoreParams) {
    const ignoreProps = arr2hash(
      aIgnoreProps || [
        "SEQUENCE",
        "DTSTAMP",
        "LAST-MODIFIED",
        "X-MOZ-GENERATION",
        "X-MICROSOFT-DISALLOW-COUNTER",
        "X-MOZ-SEND-INVITATIONS",
        "X-MOZ-SEND-INVITATIONS-UNDISCLOSED",
+        "X-MOZ-LASTACK",
+        "X-MOZ-GENERATION",
      ]
    );

A simple diff using diff -u a.ics b.ics | diff-so-fancy of a calendar synchronization of ICS files shows that these two properties are the only ones that change outside the ignored ones:

[titanism]

Adding this might actually cause errors with generation mismatch.