Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we can eliminate .primary(), then we can use that name for this function... Maybe we should do that now anyway. We want to encourage people to use the fallible option anyway. #1828

Closed
larseggert opened this issue Apr 16, 2024 · 0 comments · Fixed by #1833

Comments

@larseggert
Copy link
Collaborator

          If we can eliminate .primary(), then we can use that name for this function...  Maybe we should do that now anyway.  We want to encourage people to use the fallible option anyway.

Originally posted by @martinthomson in #1814 (comment)

larseggert added a commit to larseggert/neqo that referenced this issue Apr 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
…le()` (#1833)

* fix: `Paths::primary()` is now `Paths::primary_fallible()`

And deal with the fallout.

Fixes #1828
Fixes #1813

* Fix merge

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Update neqo-transport/src/connection/mod.rs

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* Fixups

---------

Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant