Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in [@ neqo_transport::path::Path::remote_cid] #1566

Closed
KershawChang opened this issue Jan 18, 2024 · 5 comments
Closed

Crash in [@ neqo_transport::path::Path::remote_cid] #1566

KershawChang opened this issue Jan 18, 2024 · 5 comments

Comments

@KershawChang
Copy link
Collaborator

See https://bugzilla.mozilla.org/show_bug.cgi?id=1874582
Apparently, remote_cid can be None when sending a ClosingFrame, but it's not clear why the remote_cid is not set.

@valenting
Copy link
Collaborator

See https://bugzilla.mozilla.org/show_bug.cgi?id=1881884#c0 for a way to reproduce this against the server

@larseggert
Copy link
Collaborator

@valenting Would it be sufficient to not crash and instead terminate the connection? Or is an actual fix needed?

@valenting
Copy link
Collaborator

That's definitely better than crashing.

@larseggert
Copy link
Collaborator

larseggert commented Mar 28, 2024

@KershawChang
Copy link
Collaborator Author

@KershawChang says in https://bugzilla.mozilla.org/show_bug.cgi?id=1874582#c4 this will be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1882863, i.e., #1697. So we may be done here?

Right! I think this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants