Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qlog version_information for server #1549

Closed
martinthomson opened this issue Jan 11, 2024 · 0 comments · Fixed by #1531
Closed

qlog version_information for server #1549

martinthomson opened this issue Jan 11, 2024 · 0 comments · Fixed by #1531

Comments

@martinthomson
Copy link
Member

          For the server, look in `server.rs` for `fn accept_connection(...)`.  That is where a new connection is handled.  There shouldn't be a negotiated equivalent on the server, but the recording of failed version negotiation can be recorded.

For VN, you can make a call in fn process_input(...) right where it calls PacketBuilder::version_negotiation(...), which is where the Version Negotiation packet is sent. For that, you'll need to create a new QLog instance with self.create_qlog_trace(attempt_key). You will have to follow other code for that. I probably wouldn't bother trying to reduce the number of logging events from the same remote address and DCID, because that just creates a cleanup hazard.

That won't catch all cases, but enough.

Originally posted by @martinthomson in #1505 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant