From 3ed8946e7acf1b034b2e7cbac0299ab7ff4e5376 Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Mon, 11 Mar 2024 16:08:24 +0200 Subject: [PATCH 1/3] ci: Export perf reports from benchmarks (#1731) In addition to flamegraphs and profiler.firefox.com data. --- .github/workflows/bench.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 176a80deac..ddaa606c20 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -110,6 +110,13 @@ jobs: mv server/flamegraph.svg server.svg rm neqo.svg + - name: Generate perf reports + run: | + perf report -i perf.data --no-children --stdio > transfer.perf.txt & + perf report -i client/perf.data --no-children --stdio > client.perf.txt & + perf report -i server/perf.data --no-children --stdio > server.perf.txt & + wait + - name: Cache main-branch results if: github.ref == 'refs/heads/main' uses: actions/cache/save@v4 @@ -125,6 +132,7 @@ jobs: path: | *.svg *.perf + *.txt results.* target/criterion* compression-level: 9 From cbd444187aa032ea373decbeec4f2fc0f97a4247 Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Mon, 11 Mar 2024 16:10:48 +0200 Subject: [PATCH 2/3] ci: Run `actionlint` on changes to `.github` (#1733) --- .github/actionlint-matcher.json | 17 +++++++++++++++++ .github/workflows/actionlint.yml | 26 ++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 .github/actionlint-matcher.json create mode 100644 .github/workflows/actionlint.yml diff --git a/.github/actionlint-matcher.json b/.github/actionlint-matcher.json new file mode 100644 index 0000000000..4613e1617b --- /dev/null +++ b/.github/actionlint-matcher.json @@ -0,0 +1,17 @@ +{ + "problemMatcher": [ + { + "owner": "actionlint", + "pattern": [ + { + "regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$", + "file": 1, + "line": 2, + "column": 3, + "message": 4, + "code": 5 + } + ] + } + ] +} diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml new file mode 100644 index 0000000000..f11b1b1222 --- /dev/null +++ b/.github/workflows/actionlint.yml @@ -0,0 +1,26 @@ +name: Lint GitHub Actions workflows +on: + push: + branches: ["main"] + paths: [".github"] + pull_request: + branches: ["main"] + paths: [".github"] + merge_group: + +jobs: + actionlint: + runs-on: ubuntu-latest + defaults: + run: + shell: bash + steps: + - uses: actions/checkout@v4 + - name: Download actionlint + id: get_actionlint + run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) + - name: Check workflow files + run: | + echo "::add-matcher::.github/actionlint-matcher.json" + ${{ steps.get_actionlint.outputs.executable }} -color + From b4fd4133e6e6b112ec3c4a755d098b084553c74d Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Mon, 11 Mar 2024 16:38:17 +0200 Subject: [PATCH 3/3] Fix path pattern Signed-off-by: Lars Eggert --- .github/workflows/actionlint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index f11b1b1222..1ddcfb4f09 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -2,10 +2,10 @@ name: Lint GitHub Actions workflows on: push: branches: ["main"] - paths: [".github"] + paths: [".github/**"] pull_request: branches: ["main"] - paths: [".github"] + paths: [".github/**"] merge_group: jobs: