From b210e489adf68cb03fa8ef8507bee74605935225 Mon Sep 17 00:00:00 2001 From: Max Inden Date: Thu, 7 Mar 2024 20:09:00 +0100 Subject: [PATCH] fix(client,server): re-enable clap default features When default features are disabled, clap does not e.g. generate logic for `--help` or `--version` handling. Instead it errors with the opaque error on anything other than correct command line flags. ``` $ neqo-client --version error: unexpected argument found ``` Instead of removing `default-features = false`, enable them individually. See https://docs.rs/clap/latest/clap/_features/index.html for details. --- neqo-client/Cargo.toml | 2 +- neqo-server/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/neqo-client/Cargo.toml b/neqo-client/Cargo.toml index 643eff4172..6fa361020e 100644 --- a/neqo-client/Cargo.toml +++ b/neqo-client/Cargo.toml @@ -14,7 +14,7 @@ workspace = true [dependencies] # neqo-client is not used in Firefox, so we can be liberal with dependency versions -clap = { version = "4.4", default-features = false, features = ["std", "derive"] } +clap = { version = "4.4", default-features = false, features = ["std", "color", "help", "usage", "error-context", "suggestions", "derive"] } futures = { version = "0.3", default-features = false } hex = { version = "0.4", default-features = false, features = ["std"] } log = { version = "0.4", default-features = false } diff --git a/neqo-server/Cargo.toml b/neqo-server/Cargo.toml index 203742fa06..2f2162fea0 100644 --- a/neqo-server/Cargo.toml +++ b/neqo-server/Cargo.toml @@ -14,7 +14,7 @@ workspace = true [dependencies] # neqo-server is not used in Firefox, so we can be liberal with dependency versions -clap = { version = "4.4", default-features = false, features = ["std", "derive"] } +clap = { version = "4.4", default-features = false, features = ["std", "color", "help", "usage", "error-context", "suggestions", "derive"] } futures = { version = "0.3", default-features = false, features = ["alloc"] } log = { version = "0.4", default-features = false } neqo-common = { path = "./../neqo-common", features = ["udp"] }