From 5bbd0295983e88d3a85a4b056b8a282655193cec Mon Sep 17 00:00:00 2001 From: Valentin Gosu Date: Fri, 8 Mar 2024 13:45:19 +0100 Subject: [PATCH] Priority headers should be set by the application --- neqo-http3/src/connection.rs | 3 --- neqo-http3/tests/priority.rs | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/neqo-http3/src/connection.rs b/neqo-http3/src/connection.rs index bb2b5a6ce0..287ea2c2af 100644 --- a/neqo-http3/src/connection.rs +++ b/neqo-http3/src/connection.rs @@ -835,9 +835,6 @@ impl Http3Connection { final_headers.push(Header::new(":protocol", conn_type.string())); } - if let Some(priority_header) = request.priority.header() { - final_headers.push(priority_header); - } final_headers.extend_from_slice(request.headers); Ok(final_headers) } diff --git a/neqo-http3/tests/priority.rs b/neqo-http3/tests/priority.rs index d342082d56..77d19e6fcf 100644 --- a/neqo-http3/tests/priority.rs +++ b/neqo-http3/tests/priority.rs @@ -68,7 +68,7 @@ fn priority_update() { Instant::now(), "GET", &("https", "something.com", "/"), - &[], + &[Header::new("priority", "u=4,i")], Priority::new(4, true), ) .unwrap(); @@ -129,7 +129,7 @@ fn priority_update_dont_send_for_cancelled_stream() { Instant::now(), "GET", &("https", "something.com", "/"), - &[], + &[Header::new("priority", "u=5")], Priority::new(5, false), ) .unwrap();