From 3beb0c52e40cc9370fac4ffcb6c33b2fd8985314 Mon Sep 17 00:00:00 2001
From: Max Inden <mail@max-inden.de>
Date: Fri, 5 Apr 2024 18:18:54 +0200
Subject: [PATCH] Revert "Prevent busy loop"

This reverts commit 5d314b6061ca3a056a6428373d369f0f98727f64.
---
 neqo-http3/src/send_message.rs | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/neqo-http3/src/send_message.rs b/neqo-http3/src/send_message.rs
index 6fd721a185..15965c44f6 100644
--- a/neqo-http3/src/send_message.rs
+++ b/neqo-http3/src/send_message.rs
@@ -157,11 +157,6 @@ impl SendMessage {
     fn get_stream_info(&self) -> Http3StreamInfo {
         Http3StreamInfo::new(self.stream_id(), Http3StreamType::Http)
     }
-
-    fn stream_avail_send_space(&self, conn: &Connection) -> Res<usize> {
-        conn.stream_avail_send_space(self.stream_id())
-            .map_err(|e| Error::map_stream_send_errors(&e.into()))
-    }
 }
 
 impl Stream for SendMessage {
@@ -179,7 +174,9 @@ impl SendStream for SendMessage {
         if self.stream.has_buffered_data() {
             return Ok(0);
         }
-        let available = self.stream_avail_send_space(conn)?;
+        let available = conn
+            .stream_avail_send_space(self.stream_id())
+            .map_err(|e| Error::map_stream_send_errors(&e.into()))?;
         if available <= 2 {
             return Ok(0);
         }
@@ -256,8 +253,7 @@ impl SendStream for SendMessage {
                     Error::HttpInternal(6),
                 )?;
                 qtrace!([self], "done sending request");
-            } else if self.stream_avail_send_space(conn)? > 2 {
-                // TODO: Deduplicate and document 2
+            } else {
                 // DataWritable is just a signal for an application to try to write more data,
                 // if writing fails it is fine. Therefore we do not need to properly check
                 // whether more credits are available on the transport layer.