Fix build on arm64 linux.

mutexlox-signal · padenot · commit d9be0bfca8f9 · 2024-10-07T04:55:05.000-07:00
On arm64 linux, c_char is u8. CStr::from_ptr is documented to take an i8, but this is not accurate (see rust-lang/rust#113735); instead, it takes c_char, which is sometimes but not always the same. One time it is different is on aarch64 Linux, so without this commit, cubeb-rs fails to build there.
diff --git a/cubeb-sys/src/device.rs b/cubeb-sys/src/device.rs
@@ -182,7 +182,7 @@ impl Default for cubeb_device_info {
 
 impl fmt::Debug for cubeb_device_info {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        fn optional_c_str(c_str: *const i8) -> Option<*const i8> {
+        fn optional_c_str(c_str: *const c_char) -> Option<*const c_char> {
             (unsafe { c_str.as_ref() }).map(ptr::from_ref)
         }
         f.debug_struct("cubeb_device_info")

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ impl Default for cubeb_device_info {`
`182`	`182`
`183`	`183`	`impl fmt::Debug for cubeb_device_info {`
`184`	`184`	`fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {`
`185`		`- fn optional_c_str(c_str: const i8) -> Option<const i8> {`
	`185`	`+ fn optional_c_str(c_str: const c_char) -> Option<const c_char> {`
`186`	`186`	`(unsafe { c_str.as_ref() }).map(ptr::from_ref)`
`187`	`187`	`}`
`188`	`188`	`f.debug_struct("cubeb_device_info")`