Simplify new nav for old IE styling #15874
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15874 +/- ##
=======================================
Coverage 79.28% 79.29%
=======================================
Files 159 159
Lines 8343 8347 +4
=======================================
+ Hits 6615 6619 +4
Misses 1728 1728 ☔ View full report in Codecov by Sentry. |
janbrasna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏗️ This is mostly ready, only needs a bit more documenting and testing for possible regressions. 👷
One-line summary
Streamlines the experience for IE9- and polishes a bit more in IE8- to make the site usable with m24 styling additions.
Significant changes and points to review
Protocol/base injects for otherwise base-less legacy-only pages were removed from fx/desktop too, as it was only making the experience worse, not better.
(With the switch to ESR and ESR download button macro magic, these UAs skip the download/thanks flow anyways and request direct bouncer links, so no need to enhance those paths not being taken now.)
Improved some basic alignment and added alternatives for SVG affordances.
🚧 TKTK details, features, screen captures
NB: Updates browser compatibility info in docs.
Issue / Bugzilla link
Fixes #15867
Testing
TODO: more fx-unsupported-ie tree shaking?
http://localhost:8000/en/
http://localhost:8000/fy/firefox/new/
http://localhost:8000/en/firefox/new/?xv=basic
http://localhost:8000/cy/firefox/windows/
http://localhost:8000/en/firefox/download/thanks/?xv=basic
http://localhost:8000/sco/firefox/download/thanks/
http://localhost:8000/he/firefox/all/desktop-esr/win/
http://localhost:8000/ar/about/
http://localhost:8000/el/ (og home)
http://localhost:8000/pl/ (og nav)
TODO: fresh screen captures