feat: Added Mozilla Builders to navigation (About Us) #15918
Conversation
|
Hiii @slightlyoffbeat , Thanks! 🚀 |
There was a problem hiding this comment.
Thanks @Ayushsunny ! The link looks great.
I have one requested change for moving the string to our brands.ftl file, and then this is good to go
l10n/en/navigation_refresh.ftl
Outdated
| @@ -22,6 +22,7 @@ navigation-refresh-innovation-projects-v2 = Innovation Projects | |||
| navigation-refresh-blog = Blog | |||
| navigation-refresh-our-mission = Our Mission | |||
| navigation-refresh-our-work = Our Work | |||
| navigation-refresh-mozilla-builders = { -brand-name-mozilla } Builders | |||
There was a problem hiding this comment.
I don't think we want "Builders" to be translated, so it's best to add a Brand string for "Mozilla Builders" under Mozilla projects here: https://github.com/mozilla/bedrock/blob/main/l10n/en/brands.ftl#L109
Then we can use that brand identifier here
Hii @maureenlholland I’ve made the suggested changes by moving the string to our brands.ftl file as requested. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15918 +/- ##
==========================================
+ Coverage 79.29% 79.38% +0.08%
==========================================
Files 159 159
Lines 8347 8358 +11
==========================================
+ Hits 6619 6635 +16
+ Misses 1728 1723 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks again @Ayushsunny ! Last tiny nit before merge, we need the "s"
l10n/en/brands.ftl
Outdated
| @@ -123,6 +123,7 @@ | |||
| -brand-name-mozilla-account = Mozilla account | |||
| -brand-name-mozilla-accounts = Mozilla accounts | |||
| -brand-name-mozilla-social = Mozilla.social | |||
| -brand-name-mozilla-builder = Mozilla Builder | |||
There was a problem hiding this comment.
| -brand-name-mozilla-builder = Mozilla Builder | |
| -brand-name-mozilla-builders = Mozilla Builders |
l10n/en/navigation_refresh.ftl
Outdated
| @@ -22,6 +22,7 @@ navigation-refresh-innovation-projects-v2 = Innovation Projects | |||
| navigation-refresh-blog = Blog | |||
| navigation-refresh-our-mission = Our Mission | |||
| navigation-refresh-our-work = Our Work | |||
| navigation-refresh-mozilla-builders = { -brand-name-mozilla-builder } | |||
There was a problem hiding this comment.
| navigation-refresh-mozilla-builders = { -brand-name-mozilla-builder } | |
| navigation-refresh-mozilla-builders = { -brand-name-mozilla-builders } |
Done @maureenlholland . |
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
Added Mozilla Builders to 'About Us > Our Work' in the navigation.
Significant changes and points to review
Issue / Bugzilla link
Fixes #15837
Testing