Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add-on name might be longer than 50 chars #15268

Open
1 task done
willdurand opened this issue Jan 8, 2025 · 3 comments
Open
1 task done

[Bug]: Add-on name might be longer than 50 chars #15268

willdurand opened this issue Jan 8, 2025 · 3 comments
Labels
repository:addons-server Issue relating to addons-server

Comments

@willdurand
Copy link
Member

willdurand commented Jan 8, 2025

What happened?

The name field on the Addon model is configured with a max_length set to 50 but we do have names in the wild that are longer than 50 chars.

What did you expect to happen?

All add-on names have 50 chars or less.

See also: mozilla/addons-linter#5540

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@willdurand willdurand added needs:info repository:addons-server Issue relating to addons-server labels Jan 8, 2025
@KevinMind
Copy link
Contributor

KevinMind commented Jan 8, 2025

The decision is made to make it 75 characters as chrome has the same limit and most addons are less than 75 currently.

We cannot make this a DB constraint because all translations are saved in a single table and some text should be longer than 75 characters.

@KevinMind
Copy link
Contributor

We should investigate ways to ensure you cannot bypass this limit (via locales in the manifest).

@diox
Copy link
Member

diox commented Jan 8, 2025

https://addons.mozilla.org/api/v5/addons/addon/export-tiktok-comments/ is an example with several locales going slightly over the limit (up to 55)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

4 participants