Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move glob dependency to devDependencies #5407

Closed
fregante opened this issue Aug 17, 2024 · 0 comments · Fixed by #5412
Closed

Move glob dependency to devDependencies #5407

fregante opened this issue Aug 17, 2024 · 0 comments · Fixed by #5412
Assignees
@fregante

Comments

@fregante
Copy link
Contributor

It looks like glob is used only by build scripts but it’s set as a non-dev dependency:

https://github.com/search?q=repo%3Amozilla%2Faddons-linter+require%28%27glob%27%29&type=code

Should it be moved to devDependencies? I’ll send a PR this week, checking if any other dependencies are in this situation.

Related:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregante fregante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop unused dependencies fregante/addons-linter
1 participant
@fregante