Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect commandeered revisions #384

Open
tomrittervg opened this issue Nov 14, 2024 · 2 comments
Open

Detect commandeered revisions #384

tomrittervg opened this issue Nov 14, 2024 · 2 comments
Labels
Enhancement New feature or request Medium

Comments

@tomrittervg
Copy link
Collaborator

In Bug 1930832 a developer commandeered a phab revision (which is totally fine and encouraged) and later Updatebot tried to abandon it, which failed when it couldn't. The error it got back from phabricator was:

Got an error from phabricator when trying to abandon 228765: {'error': 'ERR-CONDUIT-CORE', 'errorMessage': 'ERR-CONDUIT-CORE: <differential.revision.edit> Validation errors:\n  - You can not abandon this revision because you are not the author. You can only abandon revisions you own. You can change this behavior by adjusting the "differential.always-allow-abandon" setting in Config.', 'response': None}

We could detect this error and handle it more gracefully.

@tomrittervg tomrittervg added Enhancement New feature or request Medium labels Nov 14, 2024
@linabutler
Copy link
Member

Thanks for filing this, @tomrittervg! Would it also be possible to not close the bug as a duplicate if the revision is commandeered? I think I've commandeered Updatebot's revisions once or twice before, but always landed them before there were new upstream changes—bug 1930832 is a bit of an odd one out.

@tomrittervg
Copy link
Collaborator Author

That makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Medium
Projects
None yet
Development

No branches or pull requests

2 participants