You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Human review accuracy and speed could be improved if information about the patches applied in the patch step could be embedded automatically (perhaps in the commit message) such that it is visible in the Phabricator review. This information would also be very useful for code archeology purposes.
Right now my review process for a manual vendoring is to:
check the patch stack for changes to the related moz.yaml
read patches section of the moz.yaml, either from Searchfox, Mercurial, or from Phabricator
determine if there were any patch changes in this patch set
look at the correct version of those patches, either in Searchfox, Mercurial, or from Phabricator
check that each hunk was applied appropriately
While not unreasonable on its face, this process involves a lot of context switches.
The text was updated successfully, but these errors were encountered:
Human review accuracy and speed could be improved if information about the patches applied in the patch step could be embedded automatically (perhaps in the commit message) such that it is visible in the Phabricator review. This information would also be very useful for code archeology purposes.
Right now my review process for a manual vendoring is to:
While not unreasonable on its face, this process involves a lot of context switches.
The text was updated successfully, but these errors were encountered: