Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applied patch information such that it would be visible in the Phabricator review #327

Open
fuzzy-coats opened this issue May 11, 2023 · 0 comments

Comments

@fuzzy-coats
Copy link

Human review accuracy and speed could be improved if information about the patches applied in the patch step could be embedded automatically (perhaps in the commit message) such that it is visible in the Phabricator review. This information would also be very useful for code archeology purposes.

Right now my review process for a manual vendoring is to:

  1. check the patch stack for changes to the related moz.yaml
  2. read patches section of the moz.yaml, either from Searchfox, Mercurial, or from Phabricator
  3. determine if there were any patch changes in this patch set
  4. look at the correct version of those patches, either in Searchfox, Mercurial, or from Phabricator
  5. check that each hunk was applied appropriately

While not unreasonable on its face, this process involves a lot of context switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant