Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate router success metrics code into a common place #687

Open
data-sync-user opened this issue Apr 22, 2024 · 1 comment
Open

Consolidate router success metrics code into a common place #687

data-sync-user opened this issue Apr 22, 2024 · 1 comment
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Apr 22, 2024

Renamed from original issue “Rename storage source metric”

Currently, we use ...notification.message_data for both the storage source of the message as well as the type of message that we are passing through the bridge. This leads to confusion when reading the metric panel.

We discovered this metric isn’t necessarily misnamed but instead we should consolidate the router success metrics code into a single common place (see https://github.com/mozilla-services/autopush-rs/pull/660#pullrequestreview-2056625094 )

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

Moving this from https://mozilla-hub.atlassian.net/browse/SYNC-3448 ( https://mozilla-hub.atlassian.net/browse/SYNC-3448|smart-link ) to https://mozilla-hub.atlassian.net/browse/SYNC-3277 ( https://mozilla-hub.atlassian.net/browse/SYNC-3277|smart-link ) as this issue isn’t quite what we thought it was (badly named metric) – it’s more of what I’d say is a refactor.

@data-sync-user data-sync-user changed the title Rename storage source metric Consolidate router success metrics code into a common place Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants