Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract-major-beta-version code cleanup #4

Open
Mugurell opened this issue Jun 2, 2022 · 0 comments
Open

extract-major-beta-version code cleanup #4

Mugurell opened this issue Jun 2, 2022 · 0 comments

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jun 2, 2022

Following the recent review from #3 there are some things to improve:


And following https://github.com/mozilla-mobile/focus-android/actions/runs/2499415451 looks like we still need to update the script to support Focus.
Based on my investigations it seems like the script fails on Focus because Focus uses a "major_version .minor_version" naming scheme for branches while this action hardcodes a "major_version .minor_version .patch_version" naming scheme for branches as Fenix uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant