Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Warn if a recipe requires capabilities not present on the target #383

Open
mythmon opened this issue Aug 28, 2020 · 0 comments
Open

Warn if a recipe requires capabilities not present on the target #383

mythmon opened this issue Aug 28, 2020 · 0 comments

Comments

@mythmon
Copy link
Contributor

mythmon commented Aug 28, 2020

Recently we ran an experiment that failed because we targeted modern versions of Firefox, but we used the action preference-experiment, which is not available on modern version of Firefox. This is the kind of operations error that Normandy's capability system is designed to defend against. However, we aren't using capabilities in NDT, and so we can't leverage this information.

NDT should use the capabilities of a recipe to display warnings if they don't match the capabilities the target is expected to have. Capabilities (effectively) vary only by the version of Firefox, so pulling out the version filter object, using that to look up the capabilities, and then comparing that to the built recipe should be effective.

An example of a place to pull the list of capabilities from is here: https://archive.mozilla.org/pub/firefox/candidates/76.0-candidates/build2/linux-x86_64/en-US/firefox-76.0.normandy.json

Due to a quirk in how they are generated, capabilities are not available on Release versions, but they can be pulled from the candidates directory, which are the versions that we may potentially use for Release. The last buildN directory should be the final release version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant