Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when os is not supported #70

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,5 +161,14 @@
"useDefaultLocationExplainer": {
"message": "This is always the same location as selected in your Mozilla VPN desktop app.",
"description": "Explanation of what 'Use default Mozilla VPN Location' means."
},
"headerUnsupportedOSMessage": {
"message": "Unsupported platform"
},
"bodyUnsupportedOSMessage": {
"message": "Currently, the Mozilla VPN extension is only available on Windows devices."
},
"footnoteUnsupportedOSMessage": {
"message": "We’re working to bring support to macOS and Linux soon!"
}
}
33 changes: 33 additions & 0 deletions src/assets/img/message-os.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions src/background/vpncontroller/vpncontroller.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export class VPNController extends Component {
state: PropertyType.Bindable,
postToApp: PropertyType.Function,
isolationKey: PropertyType.Bindable,
featureList: PropertyType.Bindable,
};

get state() {
Expand All @@ -54,6 +55,10 @@ export class VPNController extends Component {
get isExcluded() {
return this.#isExcluded;
}
/** @type {IBindable<FeatureFlags>} */
get featureList() {
return this.#mFeaturelist;
}

async initNativeMessaging() {
log("initNativeMessaging");
Expand Down Expand Up @@ -150,6 +155,11 @@ export class VPNController extends Component {
this.#increaseIsolationKey();
}
break;
case "featurelist":
this.#mFeaturelist.set({
...new FeatureFlags(),
...response.featurelist,
});
default:
throw Error("Unexpeted Message type: " + response.t);
}
Expand All @@ -171,6 +181,7 @@ export class VPNController extends Component {
this.postToApp("status");
this.postToApp("servers");
this.postToApp("disabled_apps");
this.postToApp("featurelist");
});
return;
}
Expand Down Expand Up @@ -203,6 +214,8 @@ export class VPNController extends Component {
// @ts-ignore
#mServers = property([]);

#mFeaturelist = property(new FeatureFlags());

#isExcluded = property(false);
}

Expand Down Expand Up @@ -323,3 +336,8 @@ export function fromVPNStatusResponse(
}
return;
}

export class FeatureFlags {
localProxy = true;
webExtension = true;
}
17 changes: 15 additions & 2 deletions src/components/prefab-screens.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const open = (url) => {
url,
});
};
const sumoLink =
"https://support.mozilla.org/products/firefox-private-network-vpn";

const defineMessageScreen = (
tag,
Expand All @@ -20,8 +22,7 @@ const defineMessageScreen = (
primaryAction,
onPrimaryAction,
secondarAction = tr("getHelp"),
onSecondaryAction = () =>
open("https://support.mozilla.org/products/firefox-private-network-vpn")
onSecondaryAction = () => open(sumoLink)
) => {
const body =
typeof bodyText === "string" ? html`<p>${bodyText}</p>` : bodyText;
Expand Down Expand Up @@ -85,3 +86,15 @@ defineMessageScreen(
open("https://www.mozilla.org/products/vpn/download/");
}
);

defineMessageScreen(
"unsupported-os-message-screen",
"message-os.svg",
tr("headerUnsupportedOSMessage"),
html`
<p>${tr("bodyUnsupportedOSMessage")}</p>
<p class="footnote">${tr("footnoteUnsupportedOSMessage")}</p>
`,
null,
null
);
1 change: 1 addition & 0 deletions src/ui/browserAction/backend.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { getExposedObject } from "../../shared/ipc.js";
* Manually define the types for convinence, please update if making changes :)
*
* @typedef {Object} vpnController
* @property {IBindable<any>} featureList - A bindable property that contains the list or configuration of VPN servers.
* @property {IBindable<ServerCountryList>} servers - A bindable property that contains the list or configuration of VPN servers.
* @property {IBindable<Boolean>} isExcluded - A bindable property that indicates whether the VPN is excluded from certain operations.
* @property {IBindable<State>} state - A bindable property representing the current state of the VPN controller (e.g., connected, disconnected).
Expand Down
3 changes: 3 additions & 0 deletions src/ui/browserAction/popup.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
</head>
<body>
<popup-condview>
<unsupported-os-message-screen
slot="MessageOSNotSupported"
></unsupported-os-message-screen>
<install-message-screen slot="MessageInstallVPN">
</install-message-screen>
<signin-message-screen slot="MessageSignIn"></signin-message-screen>
Expand Down
19 changes: 15 additions & 4 deletions src/ui/browserAction/popupConditional.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import { ConditionalView } from "../../components/conditional-view.js";
import { propertySum } from "../../shared/property.js";
import { vpnController } from "./backend.js";

export class PopUpConditionalView extends ConditionalView {
Expand All @@ -12,9 +13,14 @@ export class PopUpConditionalView extends ConditionalView {

connectedCallback() {
super.connectedCallback();
vpnController.state.subscribe((s) => {
this.slotName = PopUpConditionalView.toSlotname(s);
});
propertySum(
vpnController.state,
vpnController.featureList,
(state, features) => {
this.slotName = PopUpConditionalView.toSlotname(state, features);
}
);

// Messages may dispatch an event requesting to send a Command to the VPN
this.addEventListener("requestMessage", (e) => {
console.log(`Message requested ${e}`);
Expand All @@ -29,17 +35,22 @@ export class PopUpConditionalView extends ConditionalView {
}

/**
* @typedef {import("../../background/vpncontroller/vpncontroller.js").FeatureFlags} FeatureFlags
* @typedef {import("../../background/vpncontroller/states.js").VPNState} State
* @param {State} state
* @param {FeatureFlags} features
* @returns {String}
*/
static toSlotname(state) {
static toSlotname(state, features) {
if (!state.installed) {
return "MessageInstallVPN";
}
if (!state.alive) {
return "MessageStartVPN";
}
if (!features.webExtension) {
return "MessageOSNotSupported";
}
if (!state.authenticated) {
return "MessageSignIn";
}
Expand Down