Add Connection Health to VPNCard #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleyjanenorton
approved these changes
Sep 23, 2024
src/components/vpncard.js
Outdated
| transform: scale(1.1); | ||
| } | ||
| .unstable .subline { | ||
| color: orange; |
There was a problem hiding this comment.
#FFA436 - let's add an env var since we need this in a few places
src/components/vpncard.js
Outdated
| color: orange; | ||
| } | ||
| .noSignal .subline { | ||
| color: red; |
There was a problem hiding this comment.
#FF6A75 - also needs env var
| svg { | ||
| height: 48px; | ||
| width: 48px; | ||
| transition: all 3s; |
There was a problem hiding this comment.
should this be .3s ? 3 seconds seems like a sloooow transition.
strseb
force-pushed
the
basti/add_signal_things
branch
from
bbbc4b6
to
2400cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: mozilla-mobile/mozilla-vpn-client#9854
Add's a stability attribute for the
<vpn-card>element. Swapping out the time string for that status.Screen.Recording.2024-09-09.at.15.23.43.mov