UI & a11y updates for the title bar icon buttons #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes the back button an 'mz-iconlink' - Adds ghost-btn styling to both the settings and back buttons
strseb
reviewed
Sep 3, 2024
strseb
reviewed
Sep 3, 2024
strseb
reviewed
Sep 3, 2024
src/components/iconbutton.js
Outdated
| url: this.href, | ||
| }); | ||
| break; | ||
| case "go-back": |
There was a problem hiding this comment.
Wondering if we need a custom event vs just setting href to null, (checking that in onclick) and just have the parent component have an @click=${goBack()} listener. That way it acts similar to an imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-02.at.2.49.27.PM.mov