Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smattering of UI tweaks #46

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Smattering of UI tweaks #46

merged 11 commits into from
Sep 2, 2024

Conversation

lesleyjanenorton
Copy link
Member

Roughly:

  • Reimplements the select location button as a button instead of a div
  • Adds .ghost-btn styling (not sure what to call these? checked out acorn for guidance but didn't see anything suitable to the purpose) and adds class to server list item buttons and the select location button.
  • Removes page bouncing when you scroll to the top or bottom of the server list.
  • Fixes the height of the popup so we don't have the strange height change when navigating between the main panel and server list panel.

@@ -55,6 +57,11 @@
--border-color: lch(from var(--panel-bg-color) calc(l + 15) c h);

--text-color-primary: white;

--button-ghost-bg-default: rgba(255, 255, 255, 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given those are shades, wondering if we can infer them from a color instead of hardcoding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea. done!

@lesleyjanenorton lesleyjanenorton merged commit d108632 into main Sep 2, 2024
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the ui-thangs branch September 2, 2024 18:46
lesleyjanenorton added a commit that referenced this pull request Sep 2, 2024
Super subtle polish tweaks to our StackView animations. Here are the
changes on top of everything in #46 .


https://github.com/user-attachments/assets/47cdfb16-253d-4577-bf29-bb0bd47fef39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants