Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basti/serverSearch #42

Merged
merged 8 commits into from
Aug 30, 2024
Merged

basti/serverSearch #42

merged 8 commits into from
Aug 30, 2024

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Aug 21, 2024

Based on top of #41 as i need icons :(

This adds server search. You can either search a city or country. If only one country is left, we auto expand it, so less clicks needed.

server.search.mp4

@strseb strseb changed the base branch from main to basti/settingsPage August 21, 2024 21:15
@strseb strseb marked this pull request as ready for review August 21, 2024 21:17
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 this is awesome!

src/components/serverlist.js Outdated Show resolved Hide resolved
let out = new ServerCountry();
out.cities = [testCity, otherTestCity];
out.code = "oh-no";
out.name = "OtherVille";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

#needsServer

Base automatically changed from basti/settingsPage to main August 30, 2024 12:03
@strseb strseb merged commit 7c2c70f into main Aug 30, 2024
5 checks passed
@strseb strseb deleted the basti/serverSearch branch August 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants