-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basti/serverSearch #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
basti/serverSearch
branch
from
August 21, 2024 21:15
f52cde2
to
9cf6c74
Compare
lesleyjanenorton
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 this is awesome!
let out = new ServerCountry(); | ||
out.cities = [testCity, otherTestCity]; | ||
out.code = "oh-no"; | ||
out.name = "OtherVille"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
#needsServer
strseb
force-pushed
the
basti/serverSearch
branch
from
August 27, 2024 11:56
2aed325
to
5770420
Compare
strseb
force-pushed
the
basti/settingsPage
branch
from
August 27, 2024 12:08
08abc53
to
d18d082
Compare
strseb
force-pushed
the
basti/serverSearch
branch
from
August 30, 2024 12:09
5770420
to
4075998
Compare
strseb
force-pushed
the
basti/serverSearch
branch
from
August 30, 2024 12:14
30bc1c7
to
1c36497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #41 as i need icons :(
This adds server search. You can either search a city or country. If only one country is left, we auto expand it, so less clicks needed.
server.search.mp4