Polish: Make The Popup Follow the Active Tab Context #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleyjanenorton
approved these changes
Aug 15, 2024
src/ui/browserAction/popupPage.js
Outdated
| @@ -51,8 +51,16 @@ export class BrowserActionPopup extends LitElement { | |||
| super(); | |||
| this.pageURL = null; | |||
| this._siteContext = null; | |||
| this.updatePage(); | |||
There was a problem hiding this comment.
Should we call updatePage() after subscribing to the controller state?
strseb
added a commit
that referenced
this pull request
Aug 21, 2024
Currently the Popup only takes the opener page into account. Let's make it follow pages, while switching. Should make it better to demo https://github.com/user-attachments/assets/e65c1d8c-d052-4c97-9792-8bd0cd5ad31a
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Popup only takes the opener page into account. Let's make it follow pages, while switching. Should make it better to demo
switch.mp4