Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap download logic with streamlit fragments. #71

Open
daavoo opened this issue Dec 17, 2024 · 0 comments
Open

Wrap download logic with streamlit fragments. #71

daavoo opened this issue Dec 17, 2024 · 0 comments
Labels
demo Related to the demo good first issue Good for newcomers help wanted Extra attention is needed

Comments

@daavoo
Copy link
Contributor

daavoo commented Dec 17, 2024 •
edited
Loading

Motivation

The current demo app refreshes after you click on the download button. This is causing some known issues #57 and potentially problems in the hosted demo.

This was first identified in #42 (review)

According to streamlit docs (https://docs.streamlit.io/develop/api-reference/widgets/st.download_button) the most recent way of handling it would be by using https://docs.streamlit.io/develop/concepts/architecture/fragments
@daavoo daavoo added the demo Related to the demo label Dec 17, 2024
@Kostis-S-Z Kostis-S-Z self-assigned this Dec 19, 2024
@Kostis-S-Z Kostis-S-Z added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2025
@Kostis-S-Z Kostis-S-Z removed their assignment Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo Related to the demo good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kostis-S-Z @daavoo