Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple-silicon implies single-threaded sylvan #600

Open
sjunges opened this issue Aug 28, 2024 · 2 comments
Open

Apple-silicon implies single-threaded sylvan #600

sjunges opened this issue Aug 28, 2024 · 2 comments
Assignees
@volkm
Labels
Apple Silicon

Comments

@sjunges
Copy link
Contributor

sjunges commented Aug 28, 2024

Based on an internal discussion.
@volkm volkm self-assigned this Aug 28, 2024
@tquatmann
Copy link
Member

If I see this correctly, we simply need to return 1u here and in line 55 if compiling on Apple silicon. Do we already use a #DEFINE ... to detect Apple silicon builds somewhere?

@volkm volkm mentioned this issue Sep 4, 2024
Merged
@volkm
Copy link
Contributor

volkm commented Sep 4, 2024

#613 adds this workaround.

To fix it, we might want to look into trolando/sylvan#42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volkm volkm

Labels
Apple Silicon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjunges @tquatmann @volkm