Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Modify the PropertyMap stage on new solution #556

Open
captain-yoshi opened this issue Apr 6, 2024 · 3 comments
Open

Add/Modify the PropertyMap stage on new solution #556

captain-yoshi opened this issue Apr 6, 2024 · 3 comments

Comments

@captain-yoshi
Copy link
Contributor

I would like to be able to add a property (which cannot be computed in advance) after a solution is found. E.g. compute the transform between a robot link and a attached collision object subframe, which would be needed by a cartesian controller.

Here are my 4 approaches to fix this. You might have other ideas.

Alpha

I could go down the PredicateFilter route and add a new wrapper that add's a callback for changing the PropertyMap on new solution.

Beta

It might be interesting to add an optional callback to the NoOp stage to #534.

Gamma

It would be nice if a callback could be set to any stage.

Delta

One could add the callback directly in the PropertyMap. As I'm writing this, I think this is the cleanest solution. No change in the API and the callback can be triggered only for the chosen solution (post-planning), as opposed to be triggered on every possible solutions while planning.

@rhaschke
Copy link
Contributor

rhaschke commented Apr 7, 2024

Probably adding a post-processing callback somewhere is the way to go. I don't yet get the idea behind your last proposal: What do you mean by adding a callback in PropertyMap? Storing a "post-processing" callback as a property?

@captain-yoshi
Copy link
Contributor Author

Yes storing a "post-processing" callback as a property.

@rhaschke
Copy link
Contributor

rhaschke commented Apr 8, 2024

Then we are on the same page. This is a reasonable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants