Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Using SCSS for styling #55

Open
jeffreydu opened this issue Sep 6, 2018 · 1 comment
Open

Using SCSS for styling #55

jeffreydu opened this issue Sep 6, 2018 · 1 comment

Comments

@jeffreydu
Copy link

Having SCSS functionality would be great for dynamic styling.

For example, I've put in a text field to allow the user to determine how many lines to limit the text to by appending a class name
image

To accommodate this, I have something like this in the CSS which doesn't look great

.clamp-line-3 {
  display: -webkit-box;
  -webkit-line-clamp: 3;
  -webkit-box-orient: vertical;
  height: auto !important;
  overflow: hidden;
}
.clamp-line-4 {
  display: -webkit-box;
  -webkit-line-clamp: 4;
  -webkit-box-orient: vertical;
  height: auto !important;
  overflow: hidden;
}
.clamp-line-5 {
  display: -webkit-box;
  -webkit-line-clamp: 5;
  -webkit-box-orient: vertical;
  height: auto !important;
  overflow: hidden;
}

If we could add functions with SCSS then we can make it look a lot cleaner.

@mnutt
Copy link
Member

mnutt commented Sep 17, 2018

I'm not sure if we would add this in for all apps, but it should be possible to add https://www.npmjs.com/package/rollup-plugin-scss to rollup.config.js to generate a dist/style.css and set the manifest's css_file to that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants